Give useful error message on common import issue. #7763
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarsir
force-pushed
the
fix-configure-import-unrelated-error-message
branch
from
bf8f16b to
9af7c76
Compare
This patch addresses aws#7758 by checking some heuristics on the string provided for import, and if it looks like a file that wasn't given the URI "file://" prefix, tell the user. This also updates the docs for "configure import" to make this requirement more clear.
tarsir
force-pushed
the
fix-configure-import-unrelated-error-message
branch
from
9af7c76 to
744b917
Compare
|
@stealthycoin Hello! I've had this PR up for a while and I was just wondering if there's anything else I should do as a non-maintainer to get it on the review queue. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #7758
Description of changes: This patch addresses #7758 by checking some heuristics on the string provided for import, and if it looks like a file that wasn't given the URI "file://" prefix, tell the user. This also updates the docs for "configure import" to make this requirement clearer.
This is my first contribution to this project, and I haven't written Python in quite a while, so please let me know if there's anything that needs changed!
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.